[bug] Unable to save dns zone when changing user's NS1 and NS2.

[zEitEr]

Hello,

It seems we've found a bug in the recent DA version. We get the following errors:

Unable to change NameServers: Cannot write zone for domain.com: 
Unable to save dns zone: named-checkzone returned:loading "domain.com" from "/var/named/domain.com.db.temp" 
class "IN" dns_master_load: /var/named/domain.com.db.temp:20: empty label
zone domain.com/IN: loading from master file /var/named/domain.com.db.temp failed: empty label
zone domain.com/IN: not loaded due to errors.

with the following details:

domain.[B][COLOR=#ff0000]com[/COLOR][/B]    14400    IN    NS    ns1.nameserver.net.
domain.[COLOR=#ff0000][B]com..[/B][/COLOR]    14400    IN    NS    ns1.nameserver.net.
domain.com.    14400    IN    NS    ns2.nameserver.net.
domain.com.    14400    IN    NS    ns2.nameserver.net.
domain.com.    14400    IN    NS    ns3.nameserver.net.

Here are the steps how to replicate the issue:

1. Create an user or use existing account in Directadmin, for example:

user: bob
domain: domain.com
nameservers: ns1.nameserver.net and ns2.nameserver.net

2. Change Name Servers for a domain of the user at admin or user level through DNS editor.

change: ns1.nameserver.net and ns2.nameserver.net
to: ns1.domain.com andns2.domain.com

3. As admin or reseller change NS1 and NS2 in user's details:

change: ns1.nameserver.net and ns2.nameserver.net
to: ns1.domain.com andns2.domain.com

Click "Save" and see the error.


The error does not effect anything as far as we see. The both NS1 and NS2 will be changed, and in user.conf we will get the ones that we specified. Namezone won't be touched because of the error, and it's fine also as NS records were already updated in our example on the step #2.

The error is confusing nevertheless, so please check and correct it.

Thanks.

 

[DirectAdmin Support]

Thanks for the report and duplication steps.
Fixed in the pre-release binaries:
http://www.directadmin.com/features.php?id=1842

This bug has actually been present since before May 2004, but was never able to duplicate it as I never thought to set the ns1/ns2 values to NS values that already existed in the zone,
and clients were never able to tell me what the trigger was until now (change User setting)
http://www.directadmin.com/features.php?id=372

Thanks!
John