Solved PHP 8 warning, can this be ignored?

[Richard G]

On compiling php 8 I've seen this warning:

PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /usr/local/directadmin/custombuild/php-8.0.25/pear/install-pear-nozlib.phar on line 339

I presume this can be safely ignored? Or should this be fixed by DA or something?

 

[Ohm J]

it can safely ignore, maybe....
it just restrict removed when declare final class method and overide it.

php7 throwing error.
php8 just show warning.

PHP 8.0: Inheritance rules are not applied to `private` class methods

PHP 8.0: Inheritance rules are not applied to `private` class methods

php.watch

but for me, it should solved this warning, because it bad code.

 

[Richard G]

but for me, it should solved this warning, because it bad code.

Agree. But I presumed should be solved by PHP then since it happens on PHP compiling?

 

[zEitEr]

PEAR is an additional component for PHP. See: https://pear.php.net There are 778 registered developers of various PEAR packages on the site. PHP developers can not respond for all of them.

 

[Richard G]

PEAR is an additional component for PHP

Thank you. As far as I know I don't have additional PEAR packages installed, could be wrong.
But if I can safely ignore this I'm happy with it.

 

[zEitEr]

The line you've posted is related to pear/install-pear-nozlib.phar
PEAR is installed by default with DirectAdmin.

 

[Richard G]

Oke thank you. But does this mean DA has to fix this?

 

[zEitEr]

I don't think so. Why would DirectAdmin developers care to track PEAR packages and update them if they are outdated?

 

[Richard G]

True. Hmmz... got a bit confused there.
In that case, that pear package needs to fix it and since it's only a warning, we can safely ignore. Then all is good.