reset_da_admin_password script contains error in line 98

[HindrikOxilion]

Hello all,

We're just building a new VM template with DirectAdmin. After cloning this to a new instance, we change several passwords, including the 'da_admin' password for MySQL, with the provided script located in: "/usr/local/directadmin/scripts/reset_da_admin_password.sh"

However, it appears there's an error in line 98, as we get this output:

/usr/local/directadmin/scripts/reset_da_admin_password.sh: line 98: [: missing `]'

Upon inspecting this line, it appears that there's indeed a missing ']'. This is the entire line 98 from the script:

if [ -s ${SETUP_TXT}; then

This looks like an oversight, and should be remedied to:

if [ -s ${SETUP_TXT} ]; then

This must be a recent change, since it used to work some time ago (sorry for not being more accurate than that). Manually downloading the latest "update.tar.gz" archive from DirectAdmin directly still contains this error at present.

Could someone fix this script for new installs?

With kind regards,

Hindrik Deelstra
Oxilion B.V.

 

[smtalk]

It's been fixed in pre-release, than you for the report!

To install pre-release on setup time, you may just use ./setup.sh auto beta

 

[factor]

beta

New feature?

 

[smtalk]

New feature?

No, it’s been there for a long time. We’ll double check the docs in case it hasn’t been mentioned there?

 

[factor]

No, it’s been there for a long time. We’ll double check the docs in case it hasn’t been mentioned there?

I shall look on your behalf.. you focus on other things..

 

[factor]

Sort of mentioned here not as part of Setup.sh

https://help.directadmin.com/item.php?id=408

not here

Updating DirectAdmin | Directadmin Docs

not here

Install guide | Directadmin Docs

@scriptkitty @smtalk

 

[HindrikOxilion]

Hey Martynas,

Thanks for looking into this, and providing a quick resolution!

With kind regards,

Hindrik Deelstra
Oxilion B.V.