Today I was unable to update via custom build and I think this is a bug, I get the following output:
So I check that PID, it doesn't exist, I check for the lock file, that doesn't exist either.
I run it again, same thing, different PID this time.
So I check the build script and i think there is a bug:
The doBubblewrap function, first line calls "quitIfLocked" function
But this function do more than quit if locked it looks like it also writes a lock file if none exists?
So after calling quitIfLocked it then checks for operating system and returns without removing the lock file if OS doesn't pass checks
quitIfLocked should be called after the OS checks or removeLockfile should be called before return?
After I make this change the ./build update_versions runs without errors
Code:
# ./build update_versions
Updating Bubblewrap
Please rely on CloudLinux CageFS for isolation of the users (cloudlinux=yes detected in the settings).
Updating PHP 7.3
Configuring /etc/container/php.handler...
Another instance of custombuild is running (lockfile: /usr/local/directadmin/custombuild/.custombuild, PID 357574).
Executing: doPhpSo I check that PID, it doesn't exist, I check for the lock file, that doesn't exist either.
I run it again, same thing, different PID this time.
So I check the build script and i think there is a bug:
The doBubblewrap function, first line calls "quitIfLocked" function
But this function do more than quit if locked it looks like it also writes a lock file if none exists?
So after calling quitIfLocked it then checks for operating system and returns without removing the lock file if OS doesn't pass checks
quitIfLocked should be called after the OS checks or removeLockfile should be called before return?
After I make this change the ./build update_versions runs without errors