Rspamd (possible) bug found in DA generated user settings conf

tlweb

Verified User
Joined
Feb 23, 2015
Messages
14
Location
Netherlands
Hi,

First of all rspamd is great. It blocks spam a million times better than spamassassin.

But there are some quirks using it in DA. And i also found a bug i think.

***BUG***
If i setup custom blacklist filters through the spamassassin settings the config file does not get generated correctly because i end up with this err
no actions in settings: exampleuser_blacklist

Now i dove into the configuration file in /etc/rspamd/user.d/exampleuser.conf

I found that it generates this:

Code:
exampleuser_blacklist {
        priority = high;
        rcpt = "exampleuser@srv1.exampleserver.nl"
        rcpt = "@exampleuser.nl"
        rcpt = "@exampleuser.nl"
        from = "@ourfine.tech"
        action {
                   reject = -999;
        }
}
When i change it to this it works fine:

Code:
exampleuser_blacklist {
        priority = high;
        rcpt = "exampleuser@srv1.exampleserver.nl"
        rcpt = "@exampleuser.nl"
        rcpt = "@exampleuser.nl"
        from = "@ourfine.tech"
        apply {
                actions {
                        reject = -999;
                }
        }
}

**Quirks***

It would be nice if the system could detect if rspamd or spamassin is enabled and would rename the menu item accordingly. Also the possibilities in blacklisting are somewhat "off" to what rspamd needs or can use.

This means i can add *@*domain.com even when rspamd is active. It doesn't throw an error saying this is not possible and it just creates a faulty config file.

Also inserting domain.com as an alternative doesn't work through the spamassassin since it needs an @ to be able to save it. Maybe DA could just strip anything before the last asterix to make sure at least the config will work as best as it can.

Kind regards,

Tom
 

tlweb

Verified User
Joined
Feb 23, 2015
Messages
14
Location
Netherlands
No reply? does this mean DA is ignoring this problem or just don't take time to reply on bug reports here?
 

DirectAdmin Support

Administrator
Staff member
Joined
Feb 27, 2003
Messages
8,920
Thanks for the report.
I've added the change:
https://directadmin.com/features.php?id=2575

Pre-release binaries are going up now, should be there in about 10 minutes.

As for reporting bugs, yes, the forum is more of a community-based support area.
If you need to contact us, please use the ticket system, and just include the related forum post so we can take a look :)

Thanks,
John
 

Albert

Verified User
Joined
Oct 25, 2019
Messages
33
before the code was
Code:
|CUSTOM9|
|*if blacklist_count>"0"|
|BLACKLIST_ID|                    {
    priority = high;
    |CUSTOM10|
|RCPT|
|blacklist_from_list|
    action                              {
        reject = -999;
|CUSTOM11|                                 }
                                                     }


If now we change for :

Code:
|CUSTOM9|
|*if blacklist_count>"0"|
|BLACKLIST_ID|                     {
    priority = high;
    |CUSTOM10|
|RCPT|
|blacklist_from_list|
    apply                                {
        actions                         {
            reject = -999;
            greylist = null;
            "add header" = null;
            |CUSTOM11|
                                                   }
                                                   }
One { is still open and } is missing to close, I'm wrong ? :confused:
 
Last edited:
Top